Conversation
…ranch in pysteps main repo to test postprocessor_plugin.
…d diagnostic (not postprocessor) This is more consistent with the structure of pysteps which has io/importers postprocessing/diagnostics
- currently we do not have ensemblestats plugins - importer and diagnostic remain as plugin types
- added plugin_function as parameter (needed for importer plugins) - updated setup script for entry_points - updated function names
correct importer prefix and remove ensemblestats for now.
ladc
left a comment
There was a problem hiding this comment.
Removed duplicate code, ensured tests work with the postprocessors_plugin branch of the main pysteps.
|
Minimum functionality assured with the tests - a test plugin is installed and correctly found in the interface methods. or for diagnostic plugins |
|
@dnerini pySTEPS/pysteps#405 implements the necessary changes into main pysteps repo. It's almost ready to be merged. Are there any old plugins that were created with the old cookiecutter? Do you know any plugins that would not work anymore? To my knowledge, there are the importers and exporters that are explicit in io.importers and io.exporters, respectively, and that were all added explicitly to io.interface.py and the ensemblestats that are explicit in postprocessing.ensemblestats. We created the new postprocessing.interface to support postprocessing plugins (i.e., plugin types diagnostic and ensemblestats for now). If anything, we should be fine if we simply add additional read from entry points with
Edit: I just merged the last suggested change into pySTEPS/pysteps#405 |
Extension of the original cookiecutter plugin template to include other plugin types and subtypes.