Load RTTMs with keep_default_na=False to avoid nan speaker label#115
Open
cifkao wants to merge 3 commits intopyannote:developfrom
Open
Load RTTMs with keep_default_na=False to avoid nan speaker label#115cifkao wants to merge 3 commits intopyannote:developfrom
keep_default_na=False to avoid nan speaker label#115cifkao wants to merge 3 commits intopyannote:developfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently,
load_rttmusespd.read_csv()withkeep_default_na=True. This results in speaker labels such as "<NA>", "nan", "NA", "N/A", and "NULL" all being parsed as the floatnanvalue.It appears that the only value that could legitimately represent a NaN/missing value in an RTTM file is
<NA>, but it seems that it would be unexpected for most (meaningful) columns, and it definitely seems incorrect to read it as a float for string columns (uri,speaker).The fix I'm proposing is therefore to pass
keep_default_na=Falseandna_values=["<NA>"], and convertnanvalues toNoneforuriandspeaker.