-
-
Notifications
You must be signed in to change notification settings - Fork 727
Adds Python 3.13 #5330
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds Python 3.13 #5330
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #5330 +/- ##
===========================================
- Coverage 98.67% 98.67% -0.01%
===========================================
Files 324 323 -1
Lines 28033 28020 -13
===========================================
- Hits 27661 27648 -13
Misses 372 372 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…s` in favour of direct entries
agriyakhetarpal
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @BradyPlanden! Nice cleanup, I remember implementing the documentation utilities over three years ago :) I restarted the Windows test where the worker crashed, otherwise it looks good to me. Could we try for Python 3.14 as well (in pybammsolvers first and then here)?
|
Thanks @agriyakhetarpal, it looks like we will have to wait for our dependencies to mature a bit more until we increment to Python 3.14. Here's the initial checklist when incrementing pybammsolvers to 3.14 and testing against this branch.
|
|
Thanks @BradyPlanden for doing the research on what's needed (and for opening the issue!). Let's go ahead with this. |
Description
docs_utilsin favour of local docstring definitions.Fixes #4539
Type of change
Please add a line in the relevant section of CHANGELOG.md to document the change (include PR #)
Important checks:
Please confirm the following before marking the PR as ready for review:
nox -s pre-commitnox -s testsnox -s doctests