Skip to content

Conversation

@BradyPlanden
Copy link
Member

@BradyPlanden BradyPlanden commented Dec 29, 2025

Description

  • Adds Python 3.13 w/ corresponding updates to CI
  • Removes docs_utils in favour of local docstring definitions.

Fixes #4539

Type of change

Please add a line in the relevant section of CHANGELOG.md to document the change (include PR #)

Important checks:

Please confirm the following before marking the PR as ready for review:

  • No style issues: nox -s pre-commit
  • All tests pass: nox -s tests
  • The documentation builds: nox -s doctests
  • Code is commented for hard-to-understand areas
  • Tests added that prove fix is effective or that feature works

@BradyPlanden BradyPlanden requested a review from a team as a code owner December 29, 2025 11:07
@codecov
Copy link

codecov bot commented Dec 29, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.67%. Comparing base (ed59259) to head (babcd8d).
⚠️ Report is 1 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #5330      +/-   ##
===========================================
- Coverage    98.67%   98.67%   -0.01%     
===========================================
  Files          324      323       -1     
  Lines        28033    28020      -13     
===========================================
- Hits         27661    27648      -13     
  Misses         372      372              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Member

@agriyakhetarpal agriyakhetarpal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @BradyPlanden! Nice cleanup, I remember implementing the documentation utilities over three years ago :) I restarted the Windows test where the worker crashed, otherwise it looks good to me. Could we try for Python 3.14 as well (in pybammsolvers first and then here)?

@BradyPlanden
Copy link
Member Author

Thanks @agriyakhetarpal, it looks like we will have to wait for our dependencies to mature a bit more until we increment to Python 3.14. Here's the initial checklist when incrementing pybammsolvers to 3.14 and testing against this branch.

@BradyPlanden BradyPlanden mentioned this pull request Dec 29, 2025
3 tasks
@agriyakhetarpal
Copy link
Member

Thanks @BradyPlanden for doing the research on what's needed (and for opening the issue!). Let's go ahead with this.

@agriyakhetarpal agriyakhetarpal merged commit 65478a8 into develop Dec 29, 2025
45 of 46 checks passed
@agriyakhetarpal agriyakhetarpal deleted the python-3.13 branch December 29, 2025 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support Python 3.13

3 participants