Skip to content

Conversation

@dyollb
Copy link

@dyollb dyollb commented Apr 13, 2025

fix merge conflicts from #225

Close #225

@ax3l ax3l added bug Something isn't working enhancement New feature or request and removed bug Something isn't working labels Jan 22, 2026
@ax3l ax3l requested review from ax3l, skarndev and virtuald January 22, 2026 08:17
@ax3l
Copy link
Contributor

ax3l commented Jan 22, 2026

@gentlegiantJGC do you like to help with the review of this one?

@gentlegiantJGC
Copy link
Contributor

gentlegiantJGC commented Jan 22, 2026

Something is wrong with the tests. I can't tell if the code is not working or if the tests are wrong.

This bit just looks like the docstring in the tests are wrong.

-      Green
+      Green : Green color

I don't understand this diff. Which is the ground truth and which is the generated? It doesn't seem to match the test files.
It is adding docstrings to the exported module level variables. Is this correct?

 Blue: ConsoleForegroundColor  # value = <ConsoleForegroundColor.Blue: 34>
+"""
+Blue color
+"""

We should also add tests for py::native_enum which I assume behaves a little different to the old enum.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants