fix progress display in Marimo#272
Conversation
|
@smutch Sorry for the late reply, I've been quite busy for a while... Thanks for looking into this. Do you think we could implement this in a way that the progressbar also still works on old marimo versions for a while? The test failures are due to the pandas 3.0 change, and should go away with a rebase. If you are busy, I can also take care of that myself though. |
|
No worries at all!
Of course. Sorry - I should have made the fix backwards compatible originally. I'll rebase and add backwards compatibility. |
b7f2465 to
1c2dc26
Compare
|
I've updated the PR to also work with marimo < 0.19.0 and rebased against main. I've tested the fix with the following marimo notebook: import marimo
__generated_with = "0.19.7"
app = marimo.App(width="medium")
@app.cell
def _():
import marimo as mo
import pymc as pm
import nutpie
return nutpie, pm
@app.cell
def _(nutpie, pm):
with pm.Model() as model:
mu = pm.Normal("mu", mu=0, sigma=1)
sigma = pm.HalfNormal("sigma", sigma=1)
obs = pm.Normal("obs", mu=mu, sigma=sigma, observed=[1.0, 2.0, 3.0])
nutpie.sample(nutpie.compile_pymc_model(model), draws=100_000)
return
if __name__ == "__main__":
app.run()Run using: and Please note that I also had to update the python dependency in pyproject.toml to |
|
Great, thank you! |
Running in the most recent release of Marimo results in the following error:
This is due to a recent refactor in Marimo's messaging module, renaming
marimo._messaging.ops.CellOptomarimo._messaging.notification_utils.CellNotificationUtils.This PR gets nutpie progress reporting working in Marimo again.