Replace deprecated testval with initval in weibull_aft notebook#749
Open
RobertoCorti wants to merge 1 commit intopymc-devs:mainfrom
Open
Replace deprecated testval with initval in weibull_aft notebook#749RobertoCorti wants to merge 1 commit intopymc-devs:mainfrom
RobertoCorti wants to merge 1 commit intopymc-devs:mainfrom
Conversation
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
fonnesbeck
approved these changes
Dec 16, 2024
Member
fonnesbeck
left a comment
fonnesbeck
left a comment
There was a problem hiding this comment.
Looks good. Appears to require a rebase.
Author
|
thanks! will do this weekend! |
Member
|
@RobertoCorti bump |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello
This pull request includes a changes to the notebook weibull_aft.ipynb to fix the usage of the deprecated
testvalargument inpm.Gammaas highlighted in Error in examples/survival_analysis/weibull_aft.ipynb #746. For that, I've substitutedtestvalwithinitval.Let me know if the fix should work and everything looks fine to you.
Thanks
Roberto
📚 Documentation preview 📚: https://pymc-examples--749.org.readthedocs.build/en/749/