Skip to content

Update PMF example#834

Merged
aloctavodia merged 4 commits intopymc-devs:mainfrom
ckrapu:update-pmf
Feb 12, 2026
Merged

Update PMF example#834
aloctavodia merged 4 commits intopymc-devs:mainfrom
ckrapu:update-pmf

Conversation

@ckrapu
Copy link
Contributor

@ckrapu ckrapu commented Jan 18, 2026

Update Probabilistic Matrix Factorization example

Address #743 and #58, updating this notebook to run cleanly and also performing some light edits for clarity and correctness.

Helpful links

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@ckrapu
Copy link
Contributor Author

ckrapu commented Jan 19, 2026

The only substantial change in the model for this notebook was a replacement of the MvNormal RVs which had a diagonal covariance matrix with independent draws from Normal instead.

One odd thing that I found was that the MAP optimization finished in <1 second on the old notebook, but took 40 seconds this time. Also, the performance difference between the mean-of-means baseline and the MAP estimate was not reproducible, but the answer we get now (MAP is closer to baseline performance instead of much worse) makes more sense to me. I also added a few bullet points to explain the dims of the various matrices.

Running MCMC for the main model takes roughly 2x as long now as well.

@ckrapu ckrapu marked this pull request as ready for review January 19, 2026 06:01
@ckrapu
Copy link
Contributor Author

ckrapu commented Jan 31, 2026

Any feedback on these edits yet?

@aloctavodia aloctavodia merged commit ab02b57 into pymc-devs:main Feb 12, 2026
2 checks passed
@aloctavodia
Copy link
Member

Thanks @ckrapu!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants