support elementwise add/sub of NormalRVs#8074
Open
eclipse1605 wants to merge 3 commits intopymc-devs:mainfrom
Open
support elementwise add/sub of NormalRVs#8074eclipse1605 wants to merge 3 commits intopymc-devs:mainfrom
eclipse1605 wants to merge 3 commits intopymc-devs:mainfrom
Conversation
Contributor
eclipse1605
commented
Jan 27, 2026
- Closes support measurable rewrites for pt.add and pt.sub of NormalRVs #8073
- Related to observe(sum) for Normal via rewrite to equivalent NormalRV #8067, ENH: pymc.math.sum could not be observed #7990
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #8074 +/- ##
==========================================
- Coverage 90.89% 90.88% -0.01%
==========================================
Files 123 123
Lines 19489 19547 +58
==========================================
+ Hits 17714 17765 +51
- Misses 1775 1782 +7
🚀 New features to boost your workflow:
|
Contributor
Author
|
@ricardoV94 do we remove the failing test or change the name and make the replacement res = conditional_logp({y_rv: y})
assert y in res |
ricardoV94
reviewed
Jan 27, 2026
Member
change it to use other RVs that don't have closed form solution |
ricardoV94
reviewed
Jan 27, 2026
ricardoV94
reviewed
Jan 27, 2026
ricardoV94
reviewed
Jan 27, 2026
ricardoV94
reviewed
Jan 27, 2026
ricardoV94
reviewed
Jan 27, 2026
ricardoV94
reviewed
Jan 27, 2026
Contributor
Author
sure ill do x_rv1 = pt.random.exponential(name="x_rv1")
x_rv2 = pt.random.exponential(name="x_rv2") |
Contributor
Author
|
@ricardoV94 the failing test if flaky right? |
Member
that's equivalent to a gamma, use different scales in each rv, to be more future proof |
ricardoV94
reviewed
Jan 28, 2026
ricardoV94
reviewed
Jan 28, 2026
ricardoV94
reviewed
Jan 28, 2026
ricardoV94
reviewed
Jan 28, 2026
ricardoV94
reviewed
Jan 28, 2026
ricardoV94
reviewed
Jan 28, 2026
ricardoV94
reviewed
Jan 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.