Fix find_constants to properly handle discrete observed data#8087
Open
hrideymarwah15 wants to merge 1 commit intopymc-devs:mainfrom
Open
Fix find_constants to properly handle discrete observed data#8087hrideymarwah15 wants to merge 1 commit intopymc-devs:mainfrom
hrideymarwah15 wants to merge 1 commit intopymc-devs:mainfrom
Conversation
Fixes pymc-devs#7851 The find_constants function was not properly filtering out observed data when the observation went through a Cast operation (e.g., for discrete distributions like Categorical or Poisson). This caused the observed data to appear in both constant_data and observed_data groups. The fix computes value_vars ancestors excluding model_vars ancestors, which properly identifies data variables that are used only as observations, even when they go through Cast or other transformation operations. This solution was suggested by @ricardoV94 in the issue discussion.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #7851
The find_constants function was not properly filtering out observed data when the observation went through a Cast operation (e.g., for discrete distributions like Categorical or Poisson). This caused the observed data to appear in both constant_data and observed_data groups.
The fix computes value_vars ancestors excluding model_vars ancestors, which properly identifies data variables that are used only as observations.