Fix domain specification docstrings for OrderedLogistic and OrderedProbit#8088
Open
hrideymarwah15 wants to merge 1 commit intopymc-devs:mainfrom
Open
Fix domain specification docstrings for OrderedLogistic and OrderedProbit#8088hrideymarwah15 wants to merge 1 commit intopymc-devs:mainfrom
hrideymarwah15 wants to merge 1 commit intopymc-devs:mainfrom
Conversation
…obit Fixes pymc-devs#7486 The docstrings incorrectly stated that ordinal data values range from 1 to K, when in fact they should be 0-indexed (ranging from 0 to K-1). Changes: - Updated OrderedLogistic docstring to indicate 0 to K-1 range - Updated OrderedProbit docstring to indicate 0 to K-1 range - Added explicit note in both classes about 0-based indexing requirement This clarifies the expected data format and helps users avoid off-by-one errors.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #7486
The docstrings incorrectly stated that ordinal data values range from 1 to K, when in fact they should be 0-indexed (ranging from 0 to K-1).
Changes: