Consolidate typing for coords using Coords and StrongCoords aliases#8094
Open
aman-coder03 wants to merge 2 commits intopymc-devs:mainfrom
Open
Consolidate typing for coords using Coords and StrongCoords aliases#8094aman-coder03 wants to merge 2 commits intopymc-devs:mainfrom
aman-coder03 wants to merge 2 commits intopymc-devs:mainfrom
Conversation
|
|
Author
|
@michaelosthege i have re-opened this PR which was earlier #7987 |
Author
|
@ricardoV94 can you please assign a label to this PR |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8094 +/- ##
==========================================
- Coverage 90.89% 89.30% -1.60%
==========================================
Files 123 123
Lines 19501 19549 +48
==========================================
- Hits 17726 17458 -268
- Misses 1775 2091 +316
🚀 New features to boost your workflow:
|
6fcb9fa to
552f711
Compare
Author
|
@ricardoV94 please have a look at this PR! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Fixes #7972
Earlier opened a PR #7987
This PR consolidates the typing of
coordsacross the codebase by introducing explicit type aliases:CoordValueCoordsStrongCoordValueStrongCoordsThese follow the existing pattern used for
Shape,Dims, andStrongDimsinshape_utils.py.Previously,
coordswere inconsistently typed across modules (e.g.Sequence,Sequence | np.ndarray,dict[str, Any]), which made downstream typing unclear and less consistent. This PR standardizes both the user-facing and normalized/internal representations.Additionally:
model.core,shape_utils, and the ArviZ backend