Replace assert checks in logprob.scan with explicit error handling#8095
Open
swarnaliiiiii wants to merge 1 commit intopymc-devs:mainfrom
Open
Replace assert checks in logprob.scan with explicit error handling#8095swarnaliiiiii wants to merge 1 commit intopymc-devs:mainfrom
swarnaliiiiii wants to merge 1 commit intopymc-devs:mainfrom
Conversation
|
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #8095 +/- ##
==========================================
- Coverage 90.89% 87.44% -3.46%
==========================================
Files 123 123
Lines 19501 19526 +25
==========================================
- Hits 17726 17074 -652
- Misses 1775 2452 +677
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
This PR replaces internal
assertchecks inlogprob.scanwith explicit, user-facing errors and adds early validation to prevent reaching those assertions.Motivation
Users working with time series models that rely on
Scan(e.g. viaCustomDist) have reported hitting internal assertions during log-probability computation, resulting in uninformativeAssertionErrors. This makes it difficult to understand why log-probability derivation failed.A concrete example is discussed in the PyMC Discourse thread:
https://discourse.pymc.io/t/smooth-local-linear-trend-with-customdist/16968
What this PR does
logprob_scanto explicitly reject scans with multiple random outputs, which are currently unsupported.assertstatements inconvert_outer_out_to_inwith explicitRuntimeErrors that explain why log-probability derivation failed.What this PR does NOT do
Related issue
addresses #7780