Draft
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #8096 +/- ##
==========================================
- Coverage 90.89% 88.03% -2.87%
==========================================
Files 123 123
Lines 19501 19511 +10
==========================================
- Hits 17726 17176 -550
- Misses 1775 2335 +560
🚀 New features to boost your workflow:
|
ba31b01 to
abfdd9e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on pymc-devs/pytensor#1882
We were registering regular TensorSharedVariables in
pymc.dims.Data, and then wrapping those inas_xtensor. The problem with that is that when you then try to act onm["x"]you were not acting on the same variable thatpymc.dims.Datareturned to you, instead you were acting on the input ofas_xtensor...This made it hard to adopt it in pymc-marketing