Open
Conversation
ricardoV94
force-pushed
the
xtensorlike
branch
from
c5676a0 to
91c5086
Compare
Member
Author
|
We have a flaky numba test going on (saw it on other PRs) |
ricardoV94
commented
Feb 11, 2026
Comment on lines
+909
to
+912
| if XARRAY_AVAILABLE: | ||
| XTensorLike: TypeAlias = Union[TensorLike, XTensorVariable, "DataArray"] | ||
| else: | ||
| XTensorLike: TypeAlias = TensorLike | XTensorVariable |
Member
Author
There was a problem hiding this comment.
Not sure about this conditional type hint, but I wanted to keep xarray optional
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Needed for projects that liked to do TensorLike, and now want to switch to XTensorLike