Skip to content

Replace ZeroSumNormal with Normal for _annual_seasonal#679

Open
maresb wants to merge 1 commit intomainfrom
maresb-patch-1
Open

Replace ZeroSumNormal with Normal for _annual_seasonal#679
maresb wants to merge 1 commit intomainfrom
maresb-patch-1

Conversation

@maresb
Copy link
Contributor

@maresb maresb commented Jan 20, 2026

I'm pretty sure you want to use Normal here instead of ZeroSumNormal. I can explain more later.


📚 Documentation preview 📚: https://causalpy--679.org.readthedocs.build/en/679/

I'm pretty sure you want to use Normal here instead of ZeroSumNormal. I can explain more later.
@codecov
Copy link

codecov bot commented Jan 20, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 94.35%. Comparing base (a67408a) to head (75a924b).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #679   +/-   ##
=======================================
  Coverage   94.35%   94.35%           
=======================================
  Files          44       44           
  Lines        7517     7517           
  Branches      456      456           
=======================================
  Hits         7093     7093           
  Misses        262      262           
  Partials      162      162           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Collaborator

@drbenvincent drbenvincent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this. Would you be able to put in a very brief explanation in the docstring (or code comment) so that this doesn't end up getting reverted in the future?

@drbenvincent drbenvincent added the bug Something isn't working label Jan 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants