feat: set icons to text color#80
Conversation
Now they can be seen with a dark theme!
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #80 +/- ##
==========================================
+ Coverage 78.90% 78.93% +0.02%
==========================================
Files 21 21
Lines 1555 1557 +2
==========================================
+ Hits 1227 1229 +2
Misses 328 328 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
I probably put the cooling on that PR, since theming in general is a slippery slope and I'm hesitate to add anything hardcoded. But I agree it should at least be visible on dark themes, by whatever means (short term or not). Thanks for this! Will look soon |
|
I'm happy to merge this as is. But it's still marked as draft. Are you indeed still wanting to do more work on it? |
|
No, no more work needed. I left it as a draft to remind myself to check in on how this relates to #48, but from what you say it seems like that PR shouldn't hold up merge here |
Now they can be seen with a dark theme!

For reference, here's how it looked before:
