[WIP] feat: use useq-schema GridFromPolygon + add grid overlap/acq mode#460
Closed
fdrgsp wants to merge 25 commits intopymmcore-plus:mainfrom
Closed
[WIP] feat: use useq-schema GridFromPolygon + add grid overlap/acq mode#460fdrgsp wants to merge 25 commits intopymmcore-plus:mainfrom
fdrgsp wants to merge 25 commits intopymmcore-plus:mainfrom
Conversation
fdrgsp
changed the title
Member
|
can we break this into two PRs? One that just replaces the built-in grid from poly with the useq one... and another one that adds the new viewer to the useq widget? |
Collaborator
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add
GridFromPolygonfromuseq-schema.This can work only after I will create a PR to pymmcore-plus/useq-schema#224 from my
useq-schemabranch: https://github.com/fdrgsp/useq-schema/tree/useq-polygon.This PR replace the local
GridFromPolygonlogic and uses theGridFromPolygonform uses-schema.It also updates
MDAWidgetto be able to receive a GridFromPolygon (I think mainly useful in position subsequences).Screen.Recording.2025-08-13.at.10.32.45.AM.mov
Add grid overlap and acquisition order to scan menu of
StageExplorerScreen.Recording.2025-08-14.at.4.01.11.PM.mov