Skip to content

Pin the actions/setup-python for the externally used action.yml#2749

Merged
joerick merged 1 commit intopypa:mainfrom
cgravill:pin_setup-python_action
Mar 1, 2026
Merged

Pin the actions/setup-python for the externally used action.yml#2749
joerick merged 1 commit intopypa:mainfrom
cgravill:pin_setup-python_action

Conversation

@cgravill
Copy link
Contributor

Minimal variation on #2744 by @agriyakhetarpal

I'm working on a project that has "Require actions to be pinned to a full-length commit SHA" enabled. I've used cibuildwheel on other projects and it's been really useful, thanks! Unfortunately the requirement for SHA pining then blocks using the cibuildwheel.

I saw on #2744 there's concerns about pinning everything, but potentially willing to pin the release part.

While I can use my fork in the project it'd be great to get this focused change in to reduce complications for folks with that setting on.

@agriyakhetarpal
Copy link
Member

Thanks for splitting this off my PR, @cgravill! I will approve this, but will ask either @henryiii or @joerick to sign it off and press merge.

@henryiii
Copy link
Contributor

I still would like to get our CI fixed :)

Yes, I'm fine with this, certainly.

@henryiii
Copy link
Contributor

@mhsmith We are getting spam-0.1.0-cp313-cp313-android_6_11_0_1018_azure_x86_64.whl is not a valid wheel on this platform in CI for Android.

@mhsmith
Copy link
Member

mhsmith commented Mar 1, 2026

This was fixed a few days ago in maturin 1.12.4, so CI has passed on a rerun.

Copy link
Contributor

@joerick joerick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah this seems fine to me. Actually I prefer the human-readable pins but if this is causing issues for people downstream this is fine.

@joerick joerick merged commit 2d33864 into pypa:main Mar 1, 2026
68 of 70 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants