SEC: avoid leaking credentials in GHA#2769
Merged
agriyakhetarpal merged 1 commit intopypa:mainfrom Mar 11, 2026
Merged
Conversation
neutrinoceros
force-pushed
the
sec/cred-leak
branch
from
64ced20 to
e76d58b
Compare
Member
There was a problem hiding this comment.
Thanks @neutrinoceros! I think we should get this in by limiting it to setting persist-credentials: false, so that the SHA-pinning discussion will take place in #2744. I assume that will be fairly agreed upon as a smaller change.
neutrinoceros
force-pushed
the
sec/cred-leak
branch
from
e76d58b to
997ebbb
Compare
Contributor
Author
|
done |
agriyakhetarpal
approved these changes
Mar 11, 2026
henryiii
approved these changes
Mar 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
based off #2762 to avoid merge conflicts later