-
Notifications
You must be signed in to change notification settings - Fork 283
Add support for abi3.abi3t tag from PEP 803 #1099
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
ngoldbaum
wants to merge
5
commits into
pypa:main
Choose a base branch
from
ngoldbaum:abi3.abi3t
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+56
−3
Draft
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
33459f0
Add support for abi3.abi3t tag from PEP 803
ngoldbaum a8e97af
fix linter
ngoldbaum dfa8bd1
Don't return compressed tag sets from cpython_tags
ngoldbaum 972f4ec
abi3t comes just after abi3 in priority
ngoldbaum 3b0a55b
Don't set the abi3t tag for GIL-enabled builds
ngoldbaum File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -1042,6 +1042,42 @@ def test_all_args(self) -> None: | |
| tags.Tag("cp313", "none", "plat2"), | ||
| ] | ||
|
|
||
| result = list(tags.cpython_tags((3, 15), ["cp315t"], ["platform"])) | ||
| assert result == [ | ||
| tags.Tag("cp315", "cp315t", "platform"), | ||
| tags.Tag("cp315", "abi3t", "platform"), | ||
| tags.Tag("cp315", "none", "platform"), | ||
| ] | ||
|
|
||
| result = list(tags.cpython_tags((3, 16), ["cp316t"], ["platform"])) | ||
| assert result == [ | ||
| tags.Tag("cp316", "cp316t", "platform"), | ||
| tags.Tag("cp316", "abi3t", "platform"), | ||
| tags.Tag("cp316", "none", "platform"), | ||
| tags.Tag("cp315", "abi3t", "platform"), | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The Discourse discussion suggests that |
||
| ] | ||
|
|
||
| result = list(tags.cpython_tags((3, 16), ["cp316"], ["platform"])) | ||
| assert result == [ | ||
| tags.Tag("cp316", "cp316", "platform"), | ||
| tags.Tag("cp316", "abi3", "platform"), | ||
| tags.Tag("cp316", "none", "platform"), | ||
| tags.Tag("cp315", "abi3", "platform"), | ||
| tags.Tag("cp314", "abi3", "platform"), | ||
| tags.Tag("cp313", "abi3", "platform"), | ||
| tags.Tag("cp312", "abi3", "platform"), | ||
| tags.Tag("cp311", "abi3", "platform"), | ||
| tags.Tag("cp310", "abi3", "platform"), | ||
| tags.Tag("cp39", "abi3", "platform"), | ||
| tags.Tag("cp38", "abi3", "platform"), | ||
| tags.Tag("cp37", "abi3", "platform"), | ||
| tags.Tag("cp36", "abi3", "platform"), | ||
| tags.Tag("cp35", "abi3", "platform"), | ||
| tags.Tag("cp34", "abi3", "platform"), | ||
| tags.Tag("cp33", "abi3", "platform"), | ||
| tags.Tag("cp32", "abi3", "platform"), | ||
| ] | ||
|
|
||
| def test_python_version_defaults(self) -> None: | ||
| tag = next(tags.cpython_tags(abis=["abi3"], platforms=["any"])) | ||
| interpreter = "cp" + tags._version_nodot(sys.version_info[:2]) | ||
|
|
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[edit: practically this could be
minor_version >= 13, but it's not worth the special case.]