Open
Conversation
henryiii
force-pushed
the
henryiii/fix/asciilocal
branch
from
5ba0fd5 to
eaf0d8b
Compare
Signed-off-by: Henry Schreiner <henryfs@princeton.edu> Co-authored-by: Jan Kaliszewski <zuo@kaliszewski.net>
henryiii
force-pushed
the
henryiii/fix/asciilocal
branch
from
eaf0d8b to
8f75707
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an alternative to and closes #470. Tests come from that PR.
Starting in Python 3.6, you can add a flag to a subsection of a regex, so we can make the matches ASCII-only without changing the surrounding whitespace matching. I'm not sure why we support non-ASCII whitespace, but this keeps support. I've added it several places where only ASCII is supported.
I expect this might be a tiny bit faster, since it's a simpler regex match, but not measurably so.