Conversation
3c9a0a1 to
3a92170
Compare
3a92170 to
a5bfabf
Compare
|
Hmm, the error (some |
|
I think we also need tests to validate non-ASCII whitespaces are removed correctly. |
* Fix validation in the packaging.version.Version's constructor * Fix validation in the packaging.specifiers.Specifier's constructor * Complement relevant tests, including adding cases related to presence of non-ASCII whitespace characters in input strings * Fix docs of packaging.version.VERSION_PATTERN by mentioning necessity of the re.ASCII flag
a5bfabf to
89ee170
Compare
OK, added. |
Co-authored-by: Pradyun Gedam <pradyunsg@gmail.com>
4e76ac3 to
83b8ac6
Compare
|
I am sorry, I miss-clicked so that these 3 workflows become required again. :-( |
|
You didn't misclick -- you did all the right things. :) It's just that GitHub requires me to click a button every time you modify a PR (It's their way to avoiding cryptomining endevours) to run our checks and I've done that now! |
|
Ah, ok. :-) |
|
What else do I need to do? |
At this point probably just be patient. We are all busy and so it might be a while until someone has time to review this PR. |
|
@zuo I've got time to review this now (sorry about the delay 😅), but there are now merge conflicts. Did you want to update the PR? |
Closes: #469.
versionin thepackaging.version.Version's constructor.specin thepackaging.specifiers.Specifier's constructor.packaging.version.VERSION_PATTERNby mentioning necessityof the
re.ASCIIflag.