Skip to content

Add compatibility for Pyodide-tagged wheels #804

Open
hoodmane wants to merge 9 commits intopypa:mainfrom
hoodmane:pyodide-compat
Open

Add compatibility for Pyodide-tagged wheels #804
hoodmane wants to merge 9 commits intopypa:mainfrom
hoodmane:pyodide-compat

Conversation

@hoodmane
Copy link

@hoodmane hoodmane commented May 21, 2024

We are changing our wheel platform tag to pyemscripten_2024_0 so we need to teach packaging to map Emscripten platform to this.

cc @henryiii

@hoodmane hoodmane changed the title Add Pyodide compatibility Add compatibility for Pyodide-tagged wheels May 21, 2024
We are changing our wheel platform tag to pyodide_2024_0 so we need to teach
packaging to map Emscripten platform to this.
@hoodmane hoodmane marked this pull request as ready for review June 7, 2024 02:05
@hoodmane
Copy link
Author

hoodmane commented Jun 7, 2024

@mayeut @henryiii @pradyunsg would appreciate review on this from any of you (and running the workflow).

@hoodmane
Copy link
Author

Tests and coverage check now pass locally for me.

@agriyakhetarpal
Copy link
Member

I stumbled into this PR, somehow – I guess the tests are valid for only Python 3.12 and should be skipped for other Python versions, @hoodmane?

@agriyakhetarpal
Copy link
Member

Now, we also pre-emptively need 2025_0 as we broke/will be breaking the ABI.

@juntyr
Copy link

juntyr commented Feb 19, 2025

+1 - it would be great if packaging installed from PyPi would just work out of the box in Pyodide

@agriyakhetarpal
Copy link
Member

I guess the only remaining parts here are to generalise the ABI tags, so that emscripten_x_y_zw and pyodide_abcd_e, where $$x, y, z, w, a, b, c, d, e ∈ [0, 9] $$ work, and skip the tests on unsupported Python versions (by probably grabbing the Python version from pyodide config get python_version)?

@ofek
Copy link
Contributor

ofek commented Oct 28, 2025

What are the next steps for this?

@hoodmane
Copy link
Author

This can only be merged once PEP 783 is approved.

@ofek
Copy link
Contributor

ofek commented Oct 28, 2025

Indeed, and what's the status of that? I haven't seen any discussion update in months so I don't quite understand the state of the proposal.

@hoodmane
Copy link
Author

hoodmane commented Oct 28, 2025

Well I assume you also asked on the discuss thread? You can see the new comments there.
https://discuss.python.org/t/pep-783-emscripten-packaging/86862/64

@ofek
Copy link
Contributor

ofek commented Oct 28, 2025

Ah I don't have notifications for that enabled apparently, thanks a lot!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants