Avoid undocumented pypa/wheel API in dist_info#3905
Closed
abravalheri wants to merge 4 commits intomainfrom
Closed
Avoid undocumented pypa/wheel API in dist_info#3905abravalheri wants to merge 4 commits intomainfrom
pypa/wheel API in dist_info#3905abravalheri wants to merge 4 commits intomainfrom
Conversation
pypa/wheel API in dist_info
This was referenced Apr 24, 2023
Merged
f7518f2 to
e5b689a
Compare
0c94f3d to
ae8ec5c
Compare
79e5761 to
c9a8429
Compare
ae8ec5c to
bdb88c0
Compare
c9a8429 to
1667b68
Compare
bdb88c0 to
f4dd7e2
Compare
1667b68 to
c03fd73
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of changes
Avoid
pypa/wheelAPI indist_infobdist_wheelto convertegg-infodirectory intodist-info, just do the conversion directly.This relies on the fact that
PKG-INFOandMETADATAfiles are compatible after the last PRs.This is done because there is an understanding that
pypa/wheelis not meant to be used public yet and will change in the future.This is part of a series of PRs:
install_requiresandextra_requiresthat deviates from core metadata #3903PKG-INFO#3904pypa/wheelAPI indist_info#3905pypa/wheelAPI ineditable_wheel#3907bdist_wheelfrompypa/wheel#3908The motivation for this series of PRs is the following:
.egg-infoand.dist-infodirectories is intertwined and implicit(See Adopt bdist_wheel from wheel project #1386).
pypa/wheelAPI which is not stable yet and is very likely to change in the future.pypa/wheelmaintainers previously described that the long term vision is to transferbdist_wheeldirectly to
setuptools(See pypa/wheel#262, pypa/wheel#472, pypa/wheel#472).Pull Request Checklist
changelog.d/.(See documentation for details)