Conversation
This commit fixes the extracted file permissions when using .extract/.extract_files in addition to when using the unpack cli command. The fix is by overriding the _extract_member method of zip file, and adding permissions fix there. The permissions fix was moved from the unpack to the new method.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #609 +/- ##
==========================================
+ Coverage 71.03% 71.23% +0.19%
==========================================
Files 13 13
Lines 1084 1088 +4
==========================================
+ Hits 770 775 +5
+ Misses 314 313 -1 ☔ View full report in Codecov by Sentry. |
|
Any plans to merge this? Anything I can do? |
|
In what situation would this change ever be used? The |
Ok, then. Your choice, I just thought you wanted this change, will close this PR. Thanks for your work :) |
|
Yeah, sorry, this was a brain fart of mine. First I OK'd this PR, then I turned it down. I guess I was just too busy with everything else and got confused, especially given how much time had passed. I don't know why I initially thought there would be a point in making the change to |
Fix #608: This commit fixes the extracted file permissions when using .extract/.extract_files in addition
to when using the unpack cli command.
The fix is by overriding the _extract_member method of zip file, and adding permissions fix there.
The permissions fix was moved from the unpack to the new method.