feat(lazer) Change methods to memory to imporove dev-ex #3338
+221
−407
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
ali-behjati
approved these changes
Jan 5, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Makes all helper functions in PythLazerLib public and standardizes parsing functions to use bytes memory instead of bytes calldata. This allows direct library calls without a wrapper contract and aligns with how payloads are received from external contract calls.
Rationale
Previously, helper functions (has*, isRequested, get) were internal, requiring a wrapper contract (PythLazerLibTestHelper) for external access. Additionally, parsing functions used bytes calldata, but when verifyUpdate returns payload data, it crosses an external call boundary and must be received as bytes memory due to ABI encoding rules. Making functions public and standardizing on memory simplifies the API and matches real-world usage patterns.
Context: https://github.com/pyth-network/pyth-examples/pull/92/files#r2631811673
How has this been tested?