Escape arguments to macro call 'create_test'#49
Merged
buddly27 merged 1 commit intopython-cmake:mainfrom Jan 19, 2025
Merged
Conversation
Contributor
Author
|
This is a weird edge case I found, because I parameterized my test with different white-space characters. It is actually really surprising and impressive that Pytest handles the escaping this way. |
Collaborator
|
Ah, good catch! I'll make the necessary adjustments to the tests over the weekend to get this merged. Thank you!
Agreed, I wouldn’t have expected it to work! |
Updated pytest_discover_tests to handle escaped characters in test names and identifiers, ensuring compatibility with parameterized tests that include such characters.
buddly27
force-pushed
the
test_name_escaping
branch
from
c700fe0 to
d751d2e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pytest does not convert escape characters in strings of parameterized tests
In CMake, if those escape characters then get converted, the test names are not found anymore.
Thus, escape the variables carefully when handling them during the test creation.