Initial support for DISCOVERY_EXTRA_ARGS for pytest test discovery#54
Merged
buddly27 merged 4 commits intopython-cmake:mainfrom Feb 17, 2025
Merged
Conversation
…pport during test discovery.
Test is expected to fail
buddly27
reviewed
Feb 16, 2025
Collaborator
buddly27
left a comment
buddly27
left a comment
There was a problem hiding this comment.
Thanks for the PR, this looks great! I'll make a few adjustments to the tests and doc before merging.
Collaborator
|
Oh also, the |
- Ensure that discovery arguments are passed when using BUNDLE_TESTS option; - Update unit tests; - Update documentation.
buddly27
approved these changes
Feb 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding initial support for pytest
DISCOVERY_EXTRA_ARGSas discussed in #53 .Refer comment: #53 (comment) for additional context.
Let me know if additional changes are needed.
Note:
I have kept the implementation minimal.
I am of the opinion that handling complex user scenarios which might break test discovery should be an onus on the user.
If they break it they should resolve the issue themselves.