Skip to content

Improve benchmarking tests #170

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
seddonym merged 2 commits into from
Jan 10, 2025
Merged

Improve benchmarking tests #170

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
95191df
Add result checks to the benchmarking tests
seddonym Jan 10, 2025
10de840
Change integration test to be for deep layers
seddonym Jan 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
46 changes: 22 additions & 24 deletions rust/tests/large.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ use std::collections::{HashMap, HashSet};
use std::fs;

#[test]
fn test_large_graph() {
fn test_large_graph_deep_layers() {
let data = fs::read_to_string("tests/large_graph.json").expect("Unable to read file");
let value: Value = serde_json::from_str(&data).unwrap();
let items: &Map<String, Value> = value.as_object().unwrap();
Expand All @@ -19,29 +19,27 @@ fn test_large_graph() {
}
let graph = ImportGraph::new(importeds_by_importer);

let levels = vec![
Level {
independent: true,
layers: vec!["plugins".to_string()],
},
Level {
independent: true,
layers: vec!["interfaces".to_string()],
},
Level {
independent: true,
layers: vec!["application".to_string()],
},
Level {
independent: true,
layers: vec!["domain".to_string()],
},
Level {
independent: true,
layers: vec!["data".to_string()],
},
let deep_layers = vec![
"mypackage.plugins.5634303718.1007553798.8198145119.application.3242334296.1991886645",
"mypackage.plugins.5634303718.1007553798.8198145119.application.3242334296.6397984863",
"mypackage.plugins.5634303718.1007553798.8198145119.application.3242334296.9009030339",
"mypackage.plugins.5634303718.1007553798.8198145119.application.3242334296.6666171185",
"mypackage.plugins.5634303718.1007553798.8198145119.application.3242334296.1693068682",
"mypackage.plugins.5634303718.1007553798.8198145119.application.3242334296.1752284225",
"mypackage.plugins.5634303718.1007553798.8198145119.application.3242334296.9089085203",
"mypackage.plugins.5634303718.1007553798.8198145119.application.3242334296.5033127033",
"mypackage.plugins.5634303718.1007553798.8198145119.application.3242334296.2454157946",
];
let containers = HashSet::from(["mypackage".to_string()]);
let levels: Vec<Level> = deep_layers
.iter()
.map(|layer| Level {
independent: true,
layers: vec![layer.to_string()],
})
.collect();
let containers = HashSet::new();

let deps = find_illegal_dependencies(&graph, &levels, &containers);

find_illegal_dependencies(&graph, &levels, &containers);
assert_eq!(deps.len(), 8);
}
188 changes: 173 additions & 15 deletions tests/benchmarking/test_benchmarking.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@
import json
from pathlib import Path
from grimp.adaptors.graph import ImportGraph
from grimp import PackageDependency, Route
import grimp


Expand All @@ -18,6 +19,21 @@ def large_graph():
return graph


TOP_LEVEL_LAYERS = ("plugins", "application", "domain", "data")
DEEP_PACKAGE = "mypackage.plugins.5634303718.1007553798.8198145119"
DEEP_LAYERS = (
f"{DEEP_PACKAGE}.application.3242334296.1991886645",
f"{DEEP_PACKAGE}.application.3242334296.6397984863",
f"{DEEP_PACKAGE}.application.3242334296.9009030339",
f"{DEEP_PACKAGE}.application.3242334296.6666171185",
f"{DEEP_PACKAGE}.application.3242334296.1693068682",
f"{DEEP_PACKAGE}.application.3242334296.1752284225",
f"{DEEP_PACKAGE}.application.3242334296.9089085203",
f"{DEEP_PACKAGE}.application.3242334296.5033127033",
f"{DEEP_PACKAGE}.application.3242334296.2454157946",
)


def test_build_django(benchmark):
"""
Benchmarks building a graph of real package - in this case Django.
Expand All @@ -34,30 +50,172 @@ def test_build_django(benchmark):
def test_top_level_large_graph(large_graph, benchmark):
benchmark(
lambda: large_graph.find_illegal_dependencies_for_layers(
layers=("plugins", "application", "domain", "data"),
layers=TOP_LEVEL_LAYERS,
containers=("mypackage",),
)
)


def test_deep_layers_large_graph(large_graph, benchmark):
layers = (
"mypackage.plugins.5634303718.1007553798.8198145119.application.3242334296.1991886645",
"mypackage.plugins.5634303718.1007553798.8198145119.application.3242334296.6397984863",
"mypackage.plugins.5634303718.1007553798.8198145119.application.3242334296.9009030339",
"mypackage.plugins.5634303718.1007553798.8198145119.application.3242334296.6666171185",
"mypackage.plugins.5634303718.1007553798.8198145119.application.3242334296.1693068682",
"mypackage.plugins.5634303718.1007553798.8198145119.application.3242334296.1752284225",
"mypackage.plugins.5634303718.1007553798.8198145119.application.3242334296.9089085203",
"mypackage.plugins.5634303718.1007553798.8198145119.application.3242334296.5033127033",
"mypackage.plugins.5634303718.1007553798.8198145119.application.3242334296.2454157946",
)
fn = lambda: large_graph.find_illegal_dependencies_for_layers(
layers=layers,
)
fn = lambda: large_graph.find_illegal_dependencies_for_layers(layers=DEEP_LAYERS)
if hasattr(benchmark, "pendantic"):
# Running with pytest-benchmark
benchmark.pedantic(fn, rounds=3)
else:
# Running with codspeed.
benchmark(fn)


# Result checks
# -------------
# These tests aren't benchmarks, but they execute the same code as the benchmarks to check the
# behaviour hasn't changed.


def test_top_level_large_graph_result_check(large_graph):
result = large_graph.find_illegal_dependencies_for_layers(
layers=TOP_LEVEL_LAYERS,
containers=("mypackage",),
)

assert result == set()


def test_deep_layers_large_graph_result_check(large_graph):
result = large_graph.find_illegal_dependencies_for_layers(layers=DEEP_LAYERS)
assert result == {
PackageDependency(
importer=f"{DEEP_PACKAGE}.application.3242334296.2454157946",
imported=f"{DEEP_PACKAGE}.application.3242334296.9089085203",
routes=frozenset(
{
Route(
heads=frozenset({f"{DEEP_PACKAGE}.application.3242334296.2454157946"}),
middle=(),
tails=frozenset({f"{DEEP_PACKAGE}.application.3242334296.9089085203"}),
)
}
),
),
PackageDependency(
importer=f"{DEEP_PACKAGE}.application.3242334296.5033127033",
imported=f"{DEEP_PACKAGE}.application.3242334296.9089085203",
routes=frozenset(
{
Route(
heads=frozenset({f"{DEEP_PACKAGE}.application.3242334296.5033127033"}),
middle=(),
tails=frozenset({f"{DEEP_PACKAGE}.application.3242334296.9089085203"}),
)
}
),
),
PackageDependency(
importer=f"{DEEP_PACKAGE}.application.3242334296.9089085203",
imported=f"{DEEP_PACKAGE}.application.3242334296.1693068682",
routes=frozenset(
{
Route(
heads=frozenset(
{
f"{DEEP_PACKAGE}.application.3242334296.9089085203.4296536723",
f"{DEEP_PACKAGE}.application.3242334296.9089085203.4641062780",
}
),
middle=(f"{DEEP_PACKAGE}.application.3242334296",),
tails=frozenset({f"{DEEP_PACKAGE}.application.3242334296.1693068682"}),
)
}
),
),
PackageDependency(
importer=f"{DEEP_PACKAGE}.application.3242334296.9089085203",
imported=f"{DEEP_PACKAGE}.application.3242334296.1752284225",
routes=frozenset(
{
Route(
heads=frozenset(
{
f"{DEEP_PACKAGE}.application.3242334296.9089085203.4296536723",
f"{DEEP_PACKAGE}.application.3242334296.9089085203.4641062780",
}
),
middle=(f"{DEEP_PACKAGE}.application.3242334296",),
tails=frozenset({f"{DEEP_PACKAGE}.application.3242334296.1752284225"}),
)
}
),
),
PackageDependency(
importer=f"{DEEP_PACKAGE}.application.3242334296.9089085203",
imported=f"{DEEP_PACKAGE}.application.3242334296.1991886645",
routes=frozenset(
{
Route(
heads=frozenset(
{
f"{DEEP_PACKAGE}.application.3242334296.9089085203.4296536723",
f"{DEEP_PACKAGE}.application.3242334296.9089085203.4641062780",
}
),
middle=(f"{DEEP_PACKAGE}.application.3242334296",),
tails=frozenset({f"{DEEP_PACKAGE}.application.3242334296.1991886645"}),
)
}
),
),
PackageDependency(
importer=f"{DEEP_PACKAGE}.application.3242334296.9089085203",
imported=f"{DEEP_PACKAGE}.application.3242334296.6397984863",
routes=frozenset(
{
Route(
heads=frozenset(
{
f"{DEEP_PACKAGE}.application.3242334296.9089085203.4296536723",
f"{DEEP_PACKAGE}.application.3242334296.9089085203.4641062780",
}
),
middle=(f"{DEEP_PACKAGE}.application.3242334296",),
tails=frozenset({f"{DEEP_PACKAGE}.application.3242334296.6397984863"}),
)
}
),
),
PackageDependency(
importer=f"{DEEP_PACKAGE}.application.3242334296.9089085203",
imported=f"{DEEP_PACKAGE}.application.3242334296.6666171185",
routes=frozenset(
{
Route(
heads=frozenset(
{
f"{DEEP_PACKAGE}.application.3242334296.9089085203.4296536723",
f"{DEEP_PACKAGE}.application.3242334296.9089085203.4641062780",
}
),
middle=(f"{DEEP_PACKAGE}.application.3242334296",),
tails=frozenset({f"{DEEP_PACKAGE}.application.3242334296.6666171185"}),
)
}
),
),
PackageDependency(
importer=f"{DEEP_PACKAGE}.application.3242334296.9089085203",
imported=f"{DEEP_PACKAGE}.application.3242334296.9009030339",
routes=frozenset(
{
Route(
heads=frozenset(
{
f"{DEEP_PACKAGE}.application.3242334296.9089085203.4296536723",
f"{DEEP_PACKAGE}.application.3242334296.9089085203.4641062780",
}
),
middle=(f"{DEEP_PACKAGE}.application.3242334296",),
tails=frozenset({f"{DEEP_PACKAGE}.application.3242334296.9009030339"}),
)
}
),
),
}
Loading