Closed
Conversation
This is the main graph implemented in Rust - but it isn't plumbed into Python yet.
This adds a wrapper around the Rust-graph in lib.rs which handles the interface between Python and Rust. At the same time, it changes the Python ImportGraph so it uses Rust instead.
This is faster, but not cryptographically safe. That shouldn't matter for our purposes.
pytest-benchmark will actually determine a suitable number of rounds+iterations automatically (typically much more than 3!). With only 3 rounds the results are quite noisy.
Rust graph (Peter)
Accessing graph.modules is more expensive than it looks.
…ule-from-public-api Remove contains_module from public API
CodSpeed Performance ReportMerging #183 will degrade performances by 99.6%Comparing Summary
Benchmarks breakdown
|
Collaborator
Author
|
Closing since we merged #184 which covers this |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.