Conversation
Collaborator
@seddonym Incase it gets buried: x-posting my remaining concern about the arrow strings here -> #188 (comment). I'm fine with whatever decision you want to take here though. |
CodSpeed Performance ReportMerging #192 will improve performances by 14.25%Comparing Summary
Benchmarks breakdown
|
49a4322 to
c8f6323
Compare
Peter554
reviewed
Mar 6, 2025
rust/src/module_expressions.rs
Outdated
| } | ||
| } | ||
|
|
||
| Ok(Regex::new(&(r"^".to_owned() + &pattern_parts.join(r".") + r"$")).unwrap()) |
Collaborator
There was a problem hiding this comment.
Should be Ok(Regex::new(&(r"^".to_owned() + &pattern_parts.join(r"\.") + r"$")).unwrap()) i.e. \. instead of .. Sorry, this one slipped past me 🙈
6395aa2 to
29916d0
Compare
Peter554
reviewed
Mar 6, 2025
Peter554
reviewed
Mar 6, 2025
Peter554
reviewed
Mar 6, 2025
Peter554
approved these changes
Mar 6, 2025
Collaborator
Peter554
left a comment
There was a problem hiding this comment.
Thanks for finishing this off, and for finding that bug!
29916d0 to
48053df
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds module expressions - most of the work is from #188, with a few tweaks on top.