Skip to content

Use joblib for more robust parallel import scanning#210

Merged
seddonym merged 1 commit intomasterfrom
joblib-multiprocessing
Apr 23, 2025
Merged

Use joblib for more robust parallel import scanning#210
seddonym merged 1 commit intomasterfrom
joblib-multiprocessing

Conversation

@seddonym
Copy link
Collaborator

@seddonym seddonym commented Apr 23, 2025

Prior to this, import scanning would crash on large codebases when
running in a container with only one available CPU when the host had
a large number of CPUs. Joblib is better than the stdlib multiprocessing
package at determining the number of available CPUs in this context.

Should fix #208, and possibly seddonym/import-linter#261.

@seddonym seddonym force-pushed the joblib-multiprocessing branch 2 times, most recently from d077400 to 4ec685d Compare April 23, 2025 13:48
@codspeed-hq
Copy link

codspeed-hq bot commented Apr 23, 2025

CodSpeed Instrumentation Performance Report

Merging #210 will not alter performance

Comparing joblib-multiprocessing (e2ac3c9) with master (6b2dd86)

Summary

✅ 22 untouched benchmarks

https://joblib.readthedocs.io/en/stable/parallel.html

Prior to this, import scanning would crash on large codebases when
running in a container with only one available CPU when the host had
a large number of CPUs. Joblib is better than the stdlib multiprocessing
package at determining the number of available CPUs in this context.
@seddonym seddonym force-pushed the joblib-multiprocessing branch from 4ec685d to e2ac3c9 Compare April 23, 2025 14:07
@seddonym seddonym marked this pull request as ready for review April 23, 2025 14:12
@seddonym seddonym merged commit 3fd90a7 into master Apr 23, 2025
18 checks passed
@seddonym seddonym deleted the joblib-multiprocessing branch April 23, 2025 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Broken pipe error when running in docker

2 participants