Conversation
CodSpeed Instrumentation Performance ReportMerging #211 will not alter performanceComparing Summary
|
seddonym
force-pushed
the
multiprocessing-env-disable
branch
2 times, most recently
from
f5ae0e0 to
e3d36e5
Compare
This provides the ability to adjust the arbitrary cut off, or turn off multiprocessing altogether.
seddonym
force-pushed
the
multiprocessing-env-disable
branch
from
b818cb5 to
f54b9a1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The multiprocessing doesn't seem to work reliably in all environments; also the optimization of the threshold of when to start doing it is somewhat arbitrary.
This exposes an environment variable to allow callers to control it. We imagine this will go away once import scanning is moved into Rust, hence the decision just to use an environment variable rather than add it to the method arguments.