Import Scanning: Split raw import extraction from import resolution#212
Merged
seddonym merged 1 commit intopython-grimp:masterfrom May 2, 2025
Merged
Conversation
CodSpeed Instrumentation Performance ReportMerging #212 will not alter performanceComparing Summary
|
Peter554
commented
May 1, 2025
Comment on lines
51
to
58
| try: | ||
| ast_tree = ast.parse(module_contents) | ||
| imported_objects = self._get_raw_imported_objects(module_contents) | ||
| except SyntaxError as e: | ||
| raise exceptions.SourceSyntaxError( | ||
| filename=module_filename, | ||
| lineno=e.lineno, | ||
| text=e.text, | ||
| ) |
Collaborator
Author
There was a problem hiding this comment.
@seddonym This is the part that https://github.com/Peter554/pyimportparse could replace.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains a pre-factor to integrating https://github.com/Peter554/pyimportparse into grimp.
This PR separates raw imported object parsing from the import resolution. This will then allow us to replace the raw imported object parsing part with pyimportparse (we can move the import resolution part over to rust in later work).