Add snapshot test for import scanning on real packages#224
Merged
seddonym merged 1 commit intopython-grimp:masterfrom Jun 17, 2025
Merged
Add snapshot test for import scanning on real packages#224seddonym merged 1 commit intopython-grimp:masterfrom
seddonym merged 1 commit intopython-grimp:masterfrom
Conversation
CodSpeed Instrumentation Performance ReportMerging #224 will not alter performanceComparing Summary
|
Peter554
force-pushed
the
snapshot-test-import-scanning
branch
2 times, most recently
from
9769927 to
7bf6e65
Compare
This snapshot test captures the results of import scanning against real packages. This gives us a lot of confidence when refactoring the import scanning code (helpful as we move more of this code over to rust). The snapshot test uses the popular syrupy[^1] pytest plugin. [^1]: https://github.com/syrupy-project/syrupy
Peter554
force-pushed
the
snapshot-test-import-scanning
branch
from
7bf6e65 to
6cd4a6f
Compare
Peter554
commented
Jun 17, 2025
| grimp.build_graph(package_name, cache_dir=None) | ||
| def test_build_graph_on_real_package(package_name, snapshot): | ||
| graph = grimp.build_graph(package_name, cache_dir=None) | ||
| imports = graph.find_matching_direct_imports(import_expression="** -> **") |
Collaborator
Author
There was a problem hiding this comment.
🧀 This gets all the imports in a flat list (results are sorted, so stable)
Collaborator
|
Thanks, I like it! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry-picked from #222
This snapshot test captures the results of import scanning against real packages. This gives us a lot of confidence when refactoring the import scanning code (helpful as we move more of this code over to rust).
The snapshot test uses the popular syrupy1 pytest plugin.
Footnotes
https://github.com/syrupy-project/syrupy ↩