gh-142927: Fix heatmap caller navigation for interior lines #143180
+124
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
pablogsal
force-pushed
the
heatmap-fix
branch
from
57f1d48 to
41c5d95
Compare
The heatmap was only showing caller buttons on function definition lines, not on interior lines within a function. This happened because callers were recorded against the function definition line but looked up by the current line number when building navigation buttons. Added a line_to_function mapping to track which function each sampled line belongs to. When building navigation buttons, callers are now looked up via the function definition line so all lines in a function show who calls that function. Callees remain line-specific since only actual call sites should show what they call. Added tests covering root, middle, and leaf frame behavior in call stacks.
pablogsal
force-pushed
the
heatmap-fix
branch
from
41c5d95 to
b3fafc1
Compare
pablogsal
commented
Dec 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The heatmap was only showing caller buttons on function definition
lines, not on interior lines within a function. This happened because
callers were recorded against the function definition line but looked
up by the current line number when building navigation buttons.
Added a line_to_function mapping to track which function each sampled
line belongs to. When building navigation buttons, callers are now
looked up via the function definition line so all lines in a function
show who calls that function. Callees remain line-specific since only
actual call sites should show what they call. Added tests covering
root, middle, and leaf frame behavior in call stacks.