Add asyncio 3.14 deprecations #15176
Open
+71
−16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Diff from mypy_primer, showing the effect of this PR on open source code: aiohttp (https://github.com/aio-libs/aiohttp)
+ aiohttp/web_urldispatcher.py:159:44: error: overload def [_P, _T] (func: def (*_P.args, **_P.kwargs) -> typing.Awaitable[_T`-2]) -> TypeGuard[def (*_P.args, **_P.kwargs) -> typing.Coroutine[Any, Any, _T`-2]] of function asyncio.coroutines.iscoroutinefunction is deprecated: Deprecated in Python 3.14; use inspect.iscoroutinefunction() instead [deprecated]
+ aiohttp/web_urldispatcher.py:159:44: note: See https://mypy.rtfd.io/en/stable/_refs.html#code-deprecated for more info [deprecated]
+ aiohttp/web_urldispatcher.py:167:44: error: overload def [_P, _T] (func: def (*_P.args, **_P.kwargs) -> typing.Awaitable[_T`-2]) -> TypeGuard[def (*_P.args, **_P.kwargs) -> typing.Coroutine[Any, Any, _T`-2]] of function asyncio.coroutines.iscoroutinefunction is deprecated: Deprecated in Python 3.14; use inspect.iscoroutinefunction() instead [deprecated]
+ aiohttp/worker.py:68:44: error: overload def [_P] (func: def (*_P.args, **_P.kwargs) -> builtins.object) -> TypeGuard[def (*_P.args, **_P.kwargs) -> typing.Coroutine[Any, Any, Any]] of function asyncio.coroutines.iscoroutinefunction is deprecated: Deprecated in Python 3.14; use inspect.iscoroutinefunction() instead [deprecated]
|
donbarbos
reviewed
Dec 26, 2025
Contributor
donbarbos
left a comment
donbarbos
left a comment
There was a problem hiding this comment.
Thank you, just suggestion about messages.
PR: python/cpython#122875
|
|
||
| if sys.version_info >= (3, 11): | ||
| @overload | ||
| @deprecated("Deprecated in Python 3.14; use inspect.iscoroutinefunction() instead") |
Contributor
There was a problem hiding this comment.
Suggested change
| @deprecated("Deprecated in Python 3.14; use inspect.iscoroutinefunction() instead") | |
| @deprecated("Deprecated since Python 3.14. Use `inspect.iscoroutinefunction()` instead.") |
| @deprecated("Deprecated in Python 3.14; use inspect.iscoroutinefunction() instead") | ||
| def iscoroutinefunction(func: Callable[..., Coroutine[Any, Any, Any]]) -> bool: ... | ||
| @overload | ||
| @deprecated("Deprecated in Python 3.14; use inspect.iscoroutinefunction() instead") |
Contributor
There was a problem hiding this comment.
Suggested change
| @deprecated("Deprecated in Python 3.14; use inspect.iscoroutinefunction() instead") | |
| @deprecated("Deprecated since Python 3.14. Use `inspect.iscoroutinefunction()` instead.") |
| @deprecated("Deprecated in Python 3.14; use inspect.iscoroutinefunction() instead") | ||
| def iscoroutinefunction(func: Callable[_P, Awaitable[_T]]) -> TypeGuard[Callable[_P, Coroutine[Any, Any, _T]]]: ... | ||
| @overload | ||
| @deprecated("Deprecated in Python 3.14; use inspect.iscoroutinefunction() instead") |
Contributor
There was a problem hiding this comment.
Suggested change
| @deprecated("Deprecated in Python 3.14; use inspect.iscoroutinefunction() instead") | |
| @deprecated("Deprecated since Python 3.14. Use `inspect.iscoroutinefunction()` instead.") |
| @deprecated("Deprecated in Python 3.14; use inspect.iscoroutinefunction() instead") | ||
| def iscoroutinefunction(func: Callable[_P, object]) -> TypeGuard[Callable[_P, Coroutine[Any, Any, Any]]]: ... | ||
| @overload | ||
| @deprecated("Deprecated in Python 3.14; use inspect.iscoroutinefunction() instead") |
Contributor
There was a problem hiding this comment.
Suggested change
| @deprecated("Deprecated in Python 3.14; use inspect.iscoroutinefunction() instead") | |
| @deprecated("Deprecated since Python 3.14. Use `inspect.iscoroutinefunction()` instead.") |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the
asyncio.iscoroutinefunctiondeprecations from #14289 with the only core change being that we only deprecate them for >= 3.11 due to @srittau's feedback here: #14074 (comment)