Fix int64 bbox rounding in perspective and elastic transforms#9354
Open
raimbekovm wants to merge 2 commits intopytorch:mainfrom
Open
Fix int64 bbox rounding in perspective and elastic transforms#9354raimbekovm wants to merge 2 commits intopytorch:mainfrom
raimbekovm wants to merge 2 commits intopytorch:mainfrom
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/vision/9354
Note: Links to docs will display an error until the docs builds have been completed. ⏳ No Failures, 1 PendingAs of commit d1d1604 with merge base 14e8cb6 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes
perspective_bounding_boxesandelastic_bounding_boxesto cast integer bounding boxes to float before format conversion, avoiding integer rounding issues.This is a follow-up to my PR #9322 which fixed the same issue in
_cxcywh_to_xyxy. The TODO comments at lines 2116 and 2440 in_geometry.py(added by @pmeier in #7215) indicated this fix was needed.Changes
perspective_bounding_boxes: Cast to float beforeconvert_bounding_box_format, convert back to original dtype at the endelastic_bounding_boxes: Same patternFollows the existing implementation in
_affine_bounding_boxes_with_expand(lines 1120-1130).