Refactor: extract shared affine helpers for keypoints and bbox#9355
Open
raimbekovm wants to merge 5 commits intopytorch:mainfrom
Open
Refactor: extract shared affine helpers for keypoints and bbox#9355raimbekovm wants to merge 5 commits intopytorch:mainfrom
raimbekovm wants to merge 5 commits intopytorch:mainfrom
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/vision/9355
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 1991aaa with merge base df421b4 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
Contributor
Author
|
Tried to fix the TorchScript type error by casting |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Extracts shared logic from
_affine_keypoints_with_expandand_affine_bounding_boxes_with_expandinto two helper functions, addressing the TODO added in PR #8817.Changes
Added two helper functions:
_create_affine_matrix()- creates transposed affine matrix for point transformation_apply_affine_expand()- computes translation and new canvas size for expand modeBoth
_affine_keypoints_with_expandand_affine_bounding_boxes_with_expandnow use these helpers, reducing code duplication.No functional changes - outputs are identical to before.