Improving tv_tensors wrap API for extensibility.#9398
Draft
gabrielfruet wants to merge 2 commits intopytorch:mainfrom
Draft
Improving tv_tensors wrap API for extensibility.#9398gabrielfruet wants to merge 2 commits intopytorch:mainfrom
gabrielfruet wants to merge 2 commits intopytorch:mainfrom
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/vision/9398
Note: Links to docs will display an error until the docs builds have been completed. ❌ 10 New Failures, 1 Unrelated FailureAs of commit 5b0311d with merge base 6940e19 ( NEW FAILURES - The following jobs have failed:
BROKEN TRUNK - The following job failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
gabrielfruet
changed the title
gabrielfruet
force-pushed
the
feat/extend-wrap
branch
from
b23ac61 to
5b0311d
Compare
zy1git
reviewed
Feb 25, 2026
Contributor
There was a problem hiding this comment.
@gabrielfruet Thanks a lot for the PR. I left two comments.
it seems that there are some test failures which need to be addressed. If you are still working on this PR, feel free to convert it to a draft. When the PR is ready to be reviewed, just convert it back.
Comment on lines
10
to
+11
| from ._tv_tensor import TVTensor | ||
| from torchvision.tv_tensors._tv_tensor import TVTensor |
Contributor
There was a problem hiding this comment.
These two lines are duplicated.
Comment on lines
+126
to
+133
| check_dims: bool | None = None, | ||
| ) -> BoundingBoxes: | ||
| return BoundingBoxes._wrap( | ||
| tensor, | ||
| format=format if format is not None else self.format, | ||
| canvas_size=canvas_size if canvas_size is not None else self.canvas_size, | ||
| clamping_mode=clamping_mode if clamping_mode is not None else self.clamping_mode, | ||
| check_dims=False, |
Contributor
There was a problem hiding this comment.
The check_dims parameter is accepted but ignored by always passing False. It should either be removed from the signature or used.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses #9333
Adopt a method-based wrapping, enabling user to extend functionality on subclasses of
TVTensor.This is the pythonic approach, since we have many built-ins that rely on this on pattern (e.g
len,iter,next...)This does not break backwards compatibility.