Skip to content

Fix Windows CI: ninja PATH and SSL certificate issues #9417

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
zy1git wants to merge 4 commits into
base: main
Choose a base branch
from
+18 −1
Draft

Fix Windows CI: ninja PATH and SSL certificate issues #9417

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
5cf3850
Fix Windows CI: ninja PATH and SSL certificate issues
Mar 4, 2026
4c0c80a
use conda ninja instead of pip ninja
Mar 4, 2026
9348745
Fix Windows ninja crash by limiting parallel jobs
Mar 4, 2026
4739fef
Reduce MAX_JOBS from 4 to 1 to fix ninja crash
Mar 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .github/scripts/unittest.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,11 @@ set -euo pipefail
# Activate conda environment
eval "$($(which conda) shell.bash hook)" && conda deactivate && conda activate ci

# Fix SSL certificate verification on Windows by using certifi's CA bundle
if [[ "$(uname)" == MSYS* ]]; then
export SSL_CERT_FILE=$(python -c "import certifi; print(certifi.where())")
fi

echo '::group::Install testing utilities'
# TODO: remove the <8 constraint on pytest when https://github.com/pytorch/vision/issues/8238 is closed
pip install --progress-bar=off "pytest<8" pytest-mock pytest-cov expecttest!=0.2.0 requests
Expand Down
10 changes: 9 additions & 1 deletion packaging/pre_build_script.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,5 +38,13 @@ else
pip install "auditwheel<6.3.0"
fi

pip install numpy pyyaml future ninja
pip install numpy pyyaml future
pip install --upgrade setuptools==72.1.0

# Use conda ninja on Windows to avoid "ReadFile: The handle is invalid" errors
# with pip-installed ninja. On other platforms, pip ninja works fine.
if [[ "$OSTYPE" == "msys" ]]; then
conda install -y ninja
else
pip install ninja
fi
4 changes: 4 additions & 0 deletions packaging/windows/internal/vc_env_helper.bat
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,10 @@ if "%CU_VERSION%" == "xpu" call "C:\Program Files (x86)\Intel\oneAPI\setvars.bat

set DISTUTILS_USE_SDK=1

REM Limit parallel jobs to avoid ninja "ReadFile: The handle is invalid" errors
REM See: https://github.com/pytorch/pytorch/issues/22450
set MAX_JOBS=1

set args=%1
shift
:start
Expand Down
Loading