Skip to content

Fix: add clamping to avoid v2.ElasticTransform IndexError when bbox equals canvas size#9436

Open
jsalvasoler wants to merge 1 commit intopytorch:mainfrom
jsalvasoler:fix/elastic-transform-index-error
Open

Fix: add clamping to avoid v2.ElasticTransform IndexError when bbox equals canvas size#9436
jsalvasoler wants to merge 1 commit intopytorch:mainfrom
jsalvasoler:fix/elastic-transform-index-error

Conversation

@jsalvasoler
Copy link

@jsalvasoler jsalvasoler commented Mar 11, 2026

elastic_bounding_boxes used bbox corner coordinates as direct indices into inv_grid (shape 1×H×W×2) without
clamping. After ceil_(), a coordinate equal to W or H (e.g. a box touching the image edge) produced index W/H,
which is out of bounds.

Fix: clamp index_x and index_y to [0, W-1] / [0, H-1] before the grid lookup, identical to the clamping already
present in elastic_keypoints

index_x.clamp_(0, inv_grid.shape[2] - 1)
index_y.clamp_(0, inv_grid.shape[1] - 1)

This was the fix suggested by @zy1git on the issue thread.
Let me know if you want me to add a test to test/test_transforms_v2.py

Fixes #9394

@pytorch-bot
Copy link

pytorch-bot bot commented Mar 11, 2026

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/vision/9436

Note: Links to docs will display an error until the docs builds have been completed.

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla
Copy link

meta-cla bot commented Mar 11, 2026

Hi @jsalvasoler!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

@jsalvasoler jsalvasoler changed the title Fix clamping to avoid v2.ElasticTransform IndexError when bbox equals canvas size to fix #9394 Fix clamping to avoid v2.ElasticTransform IndexError when bbox equals canvas size Mar 11, 2026
@meta-cla
Copy link

meta-cla bot commented Mar 11, 2026

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

@meta-cla meta-cla bot added the cla signed label Mar 11, 2026
@jsalvasoler jsalvasoler changed the title Fix clamping to avoid v2.ElasticTransform IndexError when bbox equals canvas size Fix: add clamping to avoid v2.ElasticTransform IndexError when bbox equals canvas size Mar 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

v2.ElasticTransform raises IndexError when BoundingBoxes coordinates touch the image boundary

1 participant