Conversation
TAlonglong
left a comment
There was a problem hiding this comment.
Yeah I good with thisl.
Is it your intention to drop the timeout to the put function by doing this?
trollmoves/movers.py
Outdated
| scp = self._get_scp_client() | ||
| scp.put(self.origin, self.destination.path) | ||
| success = True | ||
| break |
There was a problem hiding this comment.
Do you need the break here if you break on success further down?
There was a problem hiding this comment.
I was already pretty tired when writing that, so probably not 😅
I think we can keep the timeout option, too. |
Codecov Report
@@ Coverage Diff @@
## main #153 +/- ##
==========================================
+ Coverage 88.37% 88.55% +0.18%
==========================================
Files 22 22
Lines 4437 4492 +55
==========================================
+ Hits 3921 3978 +57
+ Misses 516 514 -2
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
This PR adds retries to the
SCPMover.copy()method. Currently there's only retries in creating the connection.VERY early work.
AUTHORS.mdif not there already