Open
Conversation
Member
|
Hi @divinity76 , would it be possible for you to modify this patch to use "SIZE_T_SPEC" as defined in tools/types.h instead of the %zu? Unfortunately the windows version of printf doesn't support %z |
Member
|
Here is an example from elsewhere in the code: error (1, ENOTSUP, "%s not multiple of " SIZE_T_SPEC " bytes", file->name, sizeof (uint32_t)); Now that I am looking at our definition in types.h, i think we may have it not entirely correct for Windows, I can correct that issue in a separate patch. |
Member
|
Even though that page indicates that Visual Studio 2015 does not support %z, it does actually seem to be supported (just tested it). Either way, I think we should still use the SIZE_T_SPEC for now. Maybe we can get rid of it later. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.