[CORRUPTED] Synthetic Benchmark PR #64536 - Allow JS root components to reinitialize on circuit restart#90
Open
tomerqodo wants to merge 2 commits intobase_pr_64536_20260121_8087from
Conversation
This was referenced Jan 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Benchmark PR dotnet#64536
Type: Corrupted (contains bugs)
Original PR Title: Allow JS root components to reinitialize on circuit restart
Original PR Description: Fixes dotnet#64523.
Tests cleanup:
This PR reverts changes to tests architecture done in dotnet#64159 to avoid fixing multiple issues in one PR. It removes the additional test file and moves
PersistentStateIsSupportedInDynamicJSRootstoPersistentState-connected test file.Framework fixes:
The goal of the changes is to differentiate between the following scenarios:
Multi-Host / Different Renderer Types (Unsupported - Throws Error)
rendererId= 0)enableJSRootComponents: With Server'srendererIdandmanagerInstancemanageris set,currentRendererId = 0enableJSRootComponents: With WebAssembly'srendererId(e.g., 1) and its ownmanagerInstance.Same Renderer Type Circuit Restart (Supported)
managervariable holds the oldDotNetObjectReferencefrom Circuit 1.currentRendererIdholds the renderer ID (e.g., Server renderer = 0)enableJSRootComponents: The framework calls this with:rendererId](e.g., 0 for Server)managerInstance(a fresh DotNetObjectReference from Circuit 2)managerInstancereplaces the old stale onehasInitializedJsComponentsis already true, so initializers don't run again.Blazor.rootComponents.add()with the new valid manager.Original PR URL: Allow JS root components to reinitialize on circuit restart dotnet/aspnetcore#64536