[CLEAN] Synthetic Benchmark PR #26845 - fix(companion): iOS event type detail fixes#547
Open
ofir-frd wants to merge 1 commit intobase_pr_26845_20260120_7395from
Open
[CLEAN] Synthetic Benchmark PR #26845 - fix(companion): iOS event type detail fixes#547ofir-frd wants to merge 1 commit intobase_pr_26845_20260120_7395from
ofir-frd wants to merge 1 commit intobase_pr_26845_20260120_7395from
Conversation
|
Hey there and thank you for opening this pull request! 👋🏼 We require pull request titles to follow the Conventional Commits specification and it looks like your proposed title needs to be adjusted. Details: |
|
This PR has been marked as stale due to inactivity. If you're still working on it or need any help, please let us know or update the PR to keep it active. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Benchmark PR calcom#26845
Type: Clean (correct implementation)
Original PR Title: fix(companion): iOS event type detail fixes
Original PR Description: ## What does this PR do?
This PR addresses 8 issues found during iOS app testing in the companion folder event type detail screen:
find()tofilter())|| "0")buildPartialUpdatePayload.tsfor proper change detectionUpdates since last revision
Mandatory Tasks (DO NOT REMOVE)
How should this be tested?
Checklist
Human Review Checklist
requiresConfirmationcomparison logic change inbuildPartialUpdatePayload.ts(lines 643-651) doesn't break existing functionalityLink to Devin run: https://app.devin.ai/sessions/9dea3de9fe1c4fb5a2188c3ef863ede1
Requested by: Dhairyashil Shinde (@dhairyashiil)
Original PR URL: calcom#26845