[CORRUPTED] Synthetic Benchmark PR #26812 - fix(api): use cal.com for bookingUrl in platform organizations#550
Open
ofir-frd wants to merge 3 commits intobase_pr_26812_20260120_2755from
Conversation
Platform organizations don't have public-facing subdomains, so non-managed users in platform orgs should get cal.com URLs instead of the platform org subdomain. - Updated EventTypeUser type to include isPlatform field - Modified buildBookingUrl to check isPlatform before using org slug - Added unit test for platform org users
|
Hey there and thank you for opening this pull request! 👋🏼 We require pull request titles to follow the Conventional Commits specification and it looks like your proposed title needs to be adjusted. Details: |
|
This PR has been marked as stale due to inactivity. If you're still working on it or need any help, please let us know or update the PR to keep it active. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Benchmark PR calcom#26812
Type: Corrupted (contains bugs)
Original PR Title: fix(api): use cal.com for bookingUrl in platform organizations
Original PR Description: ## What does this PR do?
Fixes the
bookingUrlfield in API v2 event types response for non-managed users in platform organizations.Problem
Non-managed users in platform orgs were getting incorrect booking URLs that used the platform org's subdomain:
https://gmail-platform-9041df0e-a16d-46b2-a.cal.com/dhairyashil10101010-gmail/secrethttps://cal.com/dhairyashil/secretPlatform organizations (
isPlatform: true) don't have public-facing subdomains - they're internal containers for API developers. Only regular organizations should have subdomain-based booking URLs.Solution
Updated buildBookingUrl in OutputEventTypesService_2024_06_14 to check if the organization is a platform org before using the slug for the subdomain.
Type of change
Related Issues
Fixes incorrect booking URLs in companion app for platform org users (follow-up to calcom#26195)
Original PR URL: calcom#26812
Compliance Violation