[CORRUPTED] Synthetic Benchmark PR #26951 - fix(api): add @ApiExtraModels for location types in OpenAPI spec#564
Open
ofir-frd wants to merge 1 commit intobase_pr_26951_20260120_4139from
Conversation
|
Hey there and thank you for opening this pull request! 👋🏼 We require pull request titles to follow the Conventional Commits specification and it looks like your proposed title needs to be adjusted. Details: |
|
This PR has been marked as stale due to inactivity. If you're still working on it or need any help, please let us know or update the PR to keep it active. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Benchmark PR calcom#26951
Type: Corrupted (contains bugs)
Original PR Title: fix(api): add @ApiExtraModels for location types in OpenAPI spec
Original PR Description: ## What does this PR do?
Fixes a pre-existing bug where location type schemas were referenced in the OpenAPI spec but their definitions were missing. This was causing the "Check API v2 breaking changes" CI check to fail with:
The
UpdateBookingLocationInput_2024_08_13class usesgetSchemaPath()to reference location types in its@ApiPropertyOptionaldecorator, but NestJS Swagger requires classes used withgetSchemaPath()to be registered with@ApiExtraModels()for them to be included in the generated OpenAPI spec.Changes:
@ApiExtraModelsdecorator toBookingLocationController_2024_08_13to register all location typesopenapi.jsonwhich now includes the missing schema definitionsMandatory Tasks (DO NOT REMOVE)
How should this be tested?
docs/api-reference/v2/openapi.jsoncontains schema definitions for:UpdateInputAddressLocation_2024_08_13UpdateBookingInputAttendeeAddressLocation_2024_08_13UpdateBookingInputAttendeeDefinedLocation_2024_08_13UpdateBookingInputAttendeePhoneLocation_2024_08_13UpdateBookingInputLinkLocation_2024_08_13UpdateBookingInputPhoneLocation_2024_08_13Checklist
Original PR URL: calcom#26951
Compliance Violation