Apply Version Updates From Current Changes#33
Conversation
WalkthroughThis PR consolidates patch-level enhancements and bug fixes from interim changelog entries into main CHANGELOG files across tauri-bundler and tauri-cli packages, bumps versions (bundler 2.7.2→2.7.3, cli 2.9.2→2.9.3), and unconditionally enables Sha256 hashing in bundler HTTP utilities. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In `@crates/tauri-bundler/src/utils/http_utils.rs`:
- Around line 50-59: The code maps the result of
generate_github_mirror_url_from_template(...).or_else(generate_github_mirror_url_from_base(...))
but ignores the computed alternative URL by returning url.to_owned(); change the
mapping to return the alternative URL (_alt_url) when present instead of the
original `url` so mirror env vars are used: update the closure that constructs
the tuple (ureq::Agent::config_builder()... , url.to_owned()) to use the
`_alt_url` (or rename to `alt_url`) as the second element; keep
BUNDLER_USER_AGENT and the Agent construction unchanged.
📜 Review details
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
Cargo.lockis excluded by!**/*.lock
📒 Files selected for processing (12)
.changes/bundler-user-agent.md.changes/change-pr-14379.md.changes/image-premultiply-fix.md.changes/nsis-uninstall-already-killed.mdcrates/tauri-bundler/CHANGELOG.mdcrates/tauri-bundler/Cargo.tomlcrates/tauri-bundler/src/utils/http_utils.rscrates/tauri-cli/CHANGELOG.mdcrates/tauri-cli/Cargo.tomlcrates/tauri-cli/metadata-v2.jsonpackages/cli/CHANGELOG.mdpackages/cli/package.json
💤 Files with no reviewable changes (4)
- .changes/bundler-user-agent.md
- .changes/image-premultiply-fix.md
- .changes/change-pr-14379.md
- .changes/nsis-uninstall-already-killed.md
🔇 Additional comments (8)
packages/cli/CHANGELOG.md (1)
3-11: Changelog entry looks consistent.The new 2.9.3 section follows the existing format and placement.
crates/tauri-bundler/CHANGELOG.md (1)
3-11: Changelog update is clear and well-structured.crates/tauri-bundler/Cargo.toml (1)
3-3: Version bump looks consistent.crates/tauri-cli/metadata-v2.json (1)
3-6: Metadata version bump is aligned.crates/tauri-cli/Cargo.toml (2)
3-3: Version bump looks good.
50-50: Dependency bump aligns with bundler release.packages/cli/package.json (1)
3-3: LGTM!Version bump to 2.9.3 is consistent with the related changes in
crates/tauri-cli/Cargo.tomlandmetadata-v2.json.crates/tauri-cli/CHANGELOG.md (1)
3-17: LGTM!The new changelog entry for version 2.9.3 follows the established format and conventions used throughout the file. The documented enhancements, bug fixes, and dependency upgrade align with the version bump in related files.
✏️ Tip: You can disable this entire section by setting review_details to false in your review settings.
| generate_github_mirror_url_from_template(url) | ||
| .or_else(|| generate_github_mirror_url_from_base(url)) | ||
| .map(|alt_url| { | ||
| .map(|_alt_url| { | ||
| ( | ||
| ureq::Agent::config_builder() | ||
| .user_agent(BUNDLER_USER_AGENT) | ||
| .build() | ||
| .into(), | ||
| alt_url, | ||
| url.to_owned(), | ||
| ) |
There was a problem hiding this comment.
Return the mirror URL when available.
The alternative URL is computed but ignored, so mirror env vars won’t work and the original GitHub URL is always used. That’s a regression for users behind blocked/slow GitHub access.
🛠️ Proposed fix
- .map(|_alt_url| {
+ .map(|alt_url| {
(
ureq::Agent::config_builder()
.user_agent(BUNDLER_USER_AGENT)
.build()
.into(),
- url.to_owned(),
+ alt_url,
)
})🤖 Prompt for AI Agents
In `@crates/tauri-bundler/src/utils/http_utils.rs` around lines 50 - 59, The code
maps the result of
generate_github_mirror_url_from_template(...).or_else(generate_github_mirror_url_from_base(...))
but ignores the computed alternative URL by returning url.to_owned(); change the
mapping to return the alternative URL (_alt_url) when present instead of the
original `url` so mirror env vars are used: update the closure that constructs
the tuple (ureq::Agent::config_builder()... , url.to_owned()) to use the
`_alt_url` (or rename to `alt_url`) as the second element; keep
BUNDLER_USER_AGENT and the Agent construction unchanged.
1 participant
Benchmark PR from agentic-review-benchmarks#7
Summary by CodeRabbit
New Features
Bug Fixes
Chores
✏️ Tip: You can customize this high-level summary in your review settings.