Open
Conversation
Contributor
Author
|
@maxim-v4s can you review? |
maxim-v4s
requested changes
Jan 13, 2025
Collaborator
maxim-v4s
left a comment
maxim-v4s
left a comment
There was a problem hiding this comment.
Just note: It's a little strange that CI wasn't triggered.
In my POV it's a redundant to show original error. raise from contains all info about issue cause. If you think that really needed to have this then it's needed to fix next 2 comments.
| uvicorn.run( | ||
| "qualibrate_composite.app:app", port=port, host=host, reload=reload | ||
| ) | ||
| uvicorn.run("qualibrate_composite.app:app", port=port, host=host, reload=reload) |
Collaborator
There was a problem hiding this comment.
Line too long.
80 symbols max with leading padding spaces.
| raise ImportError( | ||
| "Can't import qualibrate_runner instance. " | ||
| "Check that you have installed it." | ||
| f"Can't import qualibrate_runner instance. " |
Collaborator
There was a problem hiding this comment.
f should be used only before strings with templates.
So correct:
raise ImportError(
"Can't import qualibrate_runner instance. "
f"Check that you have installed it. Original error: {ex}"
)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently if the import of runner/core fails, the traceback is shown but the actual error isn't shown. This PR fixes that.